Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19314/TIMOB-18082]: Update toImage() signature and strip google-services library #113

Merged
merged 2 commits into from Aug 5, 2015

Conversation

hieupham007
Copy link
Contributor

@hieupham007 hieupham007 changed the title [TIMOB-19314]: Update toImage() signature. [TIMOB-19314/TIMOB-18082]: Update toImage() signature and strip google-services library Aug 4, 2015
@ashcoding
Copy link
Contributor

Code reviewed. Functionally tested. Accepted

@ashcoding
Copy link
Contributor

For Travis build to succeed, .travis.yml needs to be updated to use 4_1_X.
#114

ashcoding added a commit that referenced this pull request Aug 5, 2015
[TIMOB-19314/TIMOB-18082]: Update toImage() signature and strip google-services library
@ashcoding ashcoding merged commit a50dd64 into tidev:master Aug 5, 2015
@lokeshchdhry
Copy link
Contributor

  1. App builds fine with the module 2.3.3.
  2. The example in the module runs fine.

No issues found.

Environment:
Appc Studio : 4.2.0.201508062204
Ti SDK : 4.1.1.v20150807121809
Ti CLI : 4.0.1
Alloy : 1.6.2
MAC Yosemite : 10.10.4
Appc NPM : 4.1.0
Appc CLI : 4.1.2
Node: v0.10.37
One Plus One - android 5.0.1
Node : v0.10.37
Environment : production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants