Timob 13989 map long click #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this. |
|
Can you merge this today? |
|
Sunil, can you add documentation for this new event? |
|
And now we wait another month :-( |
|
Please merge with master and update the changelog (this is because the current version of map is recently bumped to 2.1.3). Please also include a built zip of the module. You can refer to https://github.com/appcelerator-modules/ti.map/pull/4/files as an example. |
|
Code reviewed and functionally tested. Looks good, just need to modify changelog and add a built zip. |
|
Code reviewed and functionally tested. Request accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for longClick event