timob-12787: Added support for showInfoWindow #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| since: "3.1.0" | ||
|
|
||
| - name: showInfoWindow |
There was a problem hiding this comment.
On iOS, this property is called "canShowCallout" (see https://jira.appcelerator.org/browse/TIMOB-12479). We should keep the property name the same for parity.
There was a problem hiding this comment.
This is a module, and callout doesn't mean anything to Android. I spoke with Vishal and he said its ok if I rename the property.
|
Code reviewed and functionally tested. Accepted |
jonalter
added a commit
that referenced
this pull request
Oct 24, 2013
timob-12787: Added support for showInfoWindow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing steps in JIRA.