Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to gradle #284

Merged
merged 12 commits into from Feb 3, 2020
Merged

feat: migrate to gradle #284

merged 12 commits into from Feb 3, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27724

Summary:

  • Now builds with gradle to an AAR library.
  • Packaged as a local maven repo with a POM file providing library dependency info.
  • Set min Titanium SDK version to 9.0.0.
  • Added x86_64 architecture support.
  • Migrated to AndroidX library.
  • Updated Google Maps library version to 17.0.0.

- TIMOB-27724: Build module with gradle.
- Migrated to AndroidX library.
- Added x86_64 architecture support.
- Updated Google Maps library version to 17.0.0.
@build
Copy link

build commented Jan 23, 2020

Warnings
⚠️ guid is inconsistent across platforms. It is f0d8fd44-86d2-4730-b67d-bd454577aeee in android/manifest and fee93b77-8eb3-418c-8f04-013664c4af83 in ios/manifest
⚠️ SDK version declared in Jenkinsfile (9.0.0.v20200127103011) does not match iOS' titanium.xcconfig value (9.0.0.GA)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 44 tests are passing.

📖 🎉 - congrats on your new release

New dependencies added: @seadub/danger-plugin-titanium-module.

@seadub/danger-plugin-titanium-module

Author: Chris Williams

Description: Eslint your code with Danger

Homepage: https://github.com/sgtcoolguy/danger-plugin-titanium-module#readme

Created3 days ago
Last Updated35 minutes ago
LicenseMIT
Maintainers1
Releases4
Direct Dependenciesfs-extra and semver
Keywordsdanger, danger-plugin and eslint
README

danger-plugin-titanium-module

npm version
semantic-release

Eslint your code with Danger

Usage

Install:

yarn add danger-plugin-titanium-module --dev
# OR
npm install danger-plugin-titanium-module -D

At a glance:

// dangerfile.js
import lint from 'danger-plugin-titanium-module'

await lint()

Changelog

See the GitHub release history.

Contributing

See CONTRIBUTING.md.

Generated by 🚫 dangerJS against 86c02a9

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garymathews
Copy link
Contributor

NOTE: We'll want to update Jenkinsfile when we release 9.0.0 so builds succeed. We will need to build the release .zip manually before then.

@jquick-axway
Copy link
Contributor Author

I went ahead and updated Jenkinsfile to build with 9.0.0.GA.
Since Jenkins can't build the module with 8.x.x, I might as well as update it now.

@lokeshchdhry
Copy link
Contributor

FR Passed.

Ti.map module works as expected with SDK 9.0.0+.
Checked with test app & KSV2

Module Ver: 5.0.0

@sgtcoolguy sgtcoolguy merged commit a660848 into tidev:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants