Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(jenkins): update sdk #285

Merged
merged 26 commits into from Feb 7, 2020
Merged

build(jenkins): update sdk #285

merged 26 commits into from Feb 7, 2020

Conversation

garymathews
Copy link
Contributor

No description provided.

@build
Copy link

build commented Feb 5, 2020

Warnings
⚠️ guid is inconsistent across platforms. It is f0d8fd44-86d2-4730-b67d-bd454577aeee in android/manifest and fee93b77-8eb3-418c-8f04-013664c4af83 in ios/manifest
⚠️ SDK version declared in Jenkinsfile (9.0.0.v20200207060625) does not match iOS' titanium.xcconfig value (9.0.0.v20200205142057)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 44 tests are passing.

📖 🎉 - congrats on your new release

Dependencies with modified semantic versioning:

Generated by 🚫 dangerJS against 396a9b2

@jquick-axway
Copy link
Contributor

@sgtcoolguy, the Jenkins build always fails with this PR. The log states that the Android emulator fails to startup. Happens every time we kick off a build. Perhaps that's a lie and something else is wrong?

@sgtcoolguy
Copy link
Contributor

I'm seeing the same when I try to run the android test locally. I'll have to take a deeper look

@sgtcoolguy
Copy link
Contributor

sgtcoolguy commented Feb 6, 2020

OK, I think it's unrelated to this PR and is a new issue cropping up. I suspect that the android adb binary changed in some slight way that is throwing off our emulator code to not pick up when the emulator is booted after starting it ourselves. If I have an emulator pre-booted before running, that works, but if I don't, it show stew same error as here where it thinks it's never booted fully (though it is). cc @cb1kenobi

@sgtcoolguy
Copy link
Contributor

Here's the PR for the android emulator fix: tidev/node-titanium-sdk#140

@jquick-axway
Copy link
Contributor

@sgtcoolguy, thanks for digging into this. I know we can disable snapshot support for each avd. We can do this via the emulator's GUI or via the INI file. Perhaps we should do this until you and Chris Barber come to terms on what the final CLI change should be? We can also launch the emulator with the --no-snapshot command line argument to disable it too.

@@ -1,6 +1,6 @@
{
"name": "@titanium-sdk/ti.map",
"version": "5.0.0",
"version": "5.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you did this manually, because the package-lock.json wasn't also updated. You'll need to update that files as well.

Next time, use npm --no-git-tag-version version patch and it'll update both.

@jquick-axway jquick-axway merged commit 26d1330 into tidev:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants