New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): rename property zoom to zoomLevel to avoid conflict with zoom named method. #291
Conversation
…h zoom named method. Fixes MOD-2559
|
@@ -917,7 +917,7 @@ properties: | |||
since: "3.2.3" | |||
platforms: [android] | |||
|
|||
- name: zoom | |||
- name: zoomLevel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garymathews : could you kindly confirm, if the "since" attribute for this zoomLevel property also needs to be updated? If yes, then how to determine the value?
Also, needed to confirm if the version value inside manifest file also to be incremented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it was impossible for devs to read the "zoom" property before, then yes, change the "since" to the next version of this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the suggested change is done and this PR updated for same.
@aakash-jain-axway, I noticed you updated the "package.json" file's version number. When you do this, you also need to update the "package-lock.json" by executing the below command line in the root "ti.map" directory. Can you do this please? npm install The rest of the changes look good. Thanks! |
@jquick-axway : Thanks for the information. I have executed the command mentioned, and accordingly the package-lock.json file is updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
https://jira.appcelerator.org/browse/MOD-2559