Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): rename property zoom to zoomLevel to avoid conflict with zoom named method. #291

Merged
merged 5 commits into from May 20, 2020

Conversation

aakash-jain-axway
Copy link
Contributor

@build
Copy link

build commented Apr 9, 2020

Fails
🚫 version bump was Patch in android/manifest but None in package.json
Warnings
⚠️ SDK version declared in Jenkinsfile (9.0.0.v20200207060625) does not match iOS' titanium.xcconfig value (9.0.0.GA)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 44 tests are passing.

Generated by 🚫 dangerJS against 7adc77c

@@ -917,7 +917,7 @@ properties:
since: "3.2.3"
platforms: [android]

- name: zoom
- name: zoomLevel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garymathews : could you kindly confirm, if the "since" attribute for this zoomLevel property also needs to be updated? If yes, then how to determine the value?

Also, needed to confirm if the version value inside manifest file also to be incremented?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it was impossible for devs to read the "zoom" property before, then yes, change the "since" to the next version of this module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the suggested change is done and this PR updated for same.

@jquick-axway
Copy link
Contributor

@aakash-jain-axway, I noticed you updated the "package.json" file's version number. When you do this, you also need to update the "package-lock.json" by executing the below command line in the root "ti.map" directory. Can you do this please?

npm install

The rest of the changes look good. Thanks!

@aakash-jain-axway
Copy link
Contributor Author

@aakash-jain-axway, I noticed you updated the "package.json" file's version number. When you do this, you also need to update the "package-lock.json" by executing the below command line in the root "ti.map" directory. Can you do this please?

npm install

The rest of the changes look good. Thanks!

@jquick-axway : Thanks for the information. I have executed the command mentioned, and accordingly the package-lock.json file is updated.

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@saumya-rai-axway saumya-rai-axway merged commit b5bf072 into tidev:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants