timob-13628: added zOrderOnTop support #4
Conversation
|
Ran the test case without setting zOrderOnTop on Galaxy S4 (4.2.2), but I could not reproduce the fail case. |
… into timob-13628 Conflicts: android/dist/ti.map-android-2.1.2.zip
|
Yes, the old test case is whacky. I modifed the test case to demonstrate this feature. It should now be consistent. |
|
Ran the new test case on different devices. With zOrderOnTop set to true:
|
|
My galaxy nexus (4.2) works everytime so I don't know what to say. |
| @@ -1,6 +1,7 @@ | |||
| # Change Log | |||
| <pre> | |||
| v2.1.2 Clicking on an annotation should center it in map view [TIMOB-13778]. | |||
| Added support for zOrderOnTop [TIMOB-13628]. | |||
There was a problem hiding this comment.
Need to bump the version.
|
Close the PR due to no update. |
|
Why would we close a PR for no update when the person is sitting next to you? Did you discuss it with Hieu? |
|
@negupta: We had a discussion regarding this. This feature no longer works reliably with the existing test case in the ticket. We have yet to figure out why, but it seems like an odd timing issue. I'll reopen this PR once I find a new explanation or solution to it. |
|
Makes sense. That's how we should have closed the PR instead of saying that we are closing it because of lack of update. |
… into timob-13628 Conflicts: android/dist/ti.map-android-2.1.3.zip
| @@ -5,6 +5,7 @@ v2.1.3 Fixed memory leak when removing map instance from window [TIMOB-14772] | |||
| Added support for showInfoWindow property for annotations [TIMOB-12787] | |||
|
|
|||
| v2.1.2 Clicking on an annotation should center it in map view [TIMOB-13778]. | |||
| Added support for zOrderOnTop [TIMOB-13628]. | |||
There was a problem hiding this comment.
This should be in v2.1.3.
|
FR looks good. Please address the above comment. |
|
Code reviewed and functionally tested. Accepted |
… into timob-13628 Conflicts: android/dist/ti.map-android-2.1.3.zip android/documentation/changelog.md
timob-13628: added zOrderOnTop support
testing steps in JIRA