[TIMOB-17665] Fixed user location for iOS 8 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -371,7 +392,7 @@ properties: | |||
| map. | |||
| description: | | |||
| If `true`, the user's location is marked with a pin, and the My Location button will appear in the top | |||
| right corner of the screen. | |||
| right corner of the screen. Starting in iOS 8, permissions must be added to tiapp.xml. Details in description | |||
| map.autoresizingMask = UIViewAutoresizingNone; | ||
| if ([TiUtils isIOS8OrGreater]) { |
There was a problem hiding this comment.
This condition must be reversed. if (
|
Code Reviewed. Please address comments. Also binary needs to be updated for testing |
|
Comments addressed. |
|
Code Reviewed. ACCEPTED |
|
@pec1985 please include a built zip of the module when you make a change to a module |
|
I believe he was having difficulty doing so, but the .zip file is attached to the ticket. |
|
FT pass |
jonalter
added a commit
that referenced
this pull request
Sep 15, 2014
[TIMOB-17665] Fixed user location for iOS 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in TIMOB-17665
I'm not sure how to upload the new module.zip. Git is ignoring the zip files