Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: build with sdk 9.2.0 #33

Merged
merged 1 commit into from Oct 14, 2020
Merged

build: build with sdk 9.2.0 #33

merged 1 commit into from Oct 14, 2020

Conversation

ewanharris
Copy link
Contributor

No description provided.

@build
Copy link

build commented Sep 22, 2020 •
edited

Warnings
⚠️ guid is inconsistent across platforms. It is 50513178-f1da-40e1-8031-75c08db86d6f in android/manifest and e6caa17f-c084-402c-be84-8df242d94eba in ios/manifest
⚠️ SDK version declared in Jenkinsfile (9.2.0.v20200921095451) does not match iOS' titanium.xcconfig value (9.2.0.GA)
Messages
📖

💾 Here are the artifacts produced:
📖

✅ All tests are passing
Nice one! All 73 tests are passing.
📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against db0114e

sgtcoolguy
sgtcoolguy approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewanharris ewanharris merged commit 3014711 into tidev:master Oct 14, 2020
@ewanharris ewanharris deleted the 920 branch October 14, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewanharris @build @sgtcoolguy