Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to 17.5.0 and backgrounding support #39

Merged
merged 9 commits into from Nov 4, 2020
Merged

feat: update to 17.5.0 and backgrounding support #39

merged 9 commits into from Nov 4, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jun 4, 2020 •
edited

JIRA:

Summary:

  • Updated play services library from 17.1.1 to 17.5.0.
  • Changed makeGooglePlayServicesAvailable() method to use native implementation.
    • Now shows Google's standard dialog if Play Services needs to be updated.
    • Couldn't use native implementation before because backing out of the activity that was hosting this dialog used to crash on Google's end. Google has now fixed it.
  • Updated module's bootstrap to use new showUI() method.
    • This supports our new "run-in-background" feature. See: TIMOB-27896
    • We show bootstrap's UI every time a new UI session begins for the same JS runtime.

@jquick-axway
feat: makeGooglePlayServicesAvailable() now uses native implementation
0ecb91b 
- Google fixed exception that used to occur when backing out of activity that hosted dialog.
@jquick-axway
feat: updated play services lib to 17.3.0
96cff33
@jquick-axway
feat: added "run-in-background" support
c1827bf 
- Titanium 9.1.0 supports running Titanium's JS runtime in the background without UI.
- Requires change to bootstraps that show UI. They now must use async showUI() method instead of execute() method.
@jquick-axway jquick-axway mentioned this pull request Jun 4, 2020
Closed
@build
Copy link

build commented Jun 4, 2020 •
edited

Messages
📖

💾 Here are the artifacts produced:
📖

✅ All tests are passing
Nice one! All 12 tests are passing.
📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against c162e08

@jquick-axway jquick-axway mentioned this pull request Jun 4, 2020
Open
@dependabot-preview dependabot-preview bot mentioned this pull request Sep 15, 2020
Closed
garymathews
garymathews approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garymathews
Copy link
Contributor

Need to fix conflicts, may want to bump Jenkins build SDK

@jquick-axway
Copy link
Contributor Author

Updated PR:

  • Updated to Google Play Services 17.5.0.
  • Modified bootstrap to support TIMOB-27896 backgrounding feature dynamically.
  • Reverted minsdk from 9.3.0 to 9.0.0.

@jquick-axway jquick-axway changed the title feat: enhancements for Titanium 9.1.0 feat: update to 17.5.0 and backgrounding support Nov 3, 2020
garymathews
garymathews approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jquick-axway jquick-axway merged commit 4a030a9 into tidev:master Nov 4, 2020
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @build @garymathews