New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support iOS 13 auth-policy constants #34
Conversation
It'd be good to add unit tests for the new constants... |
@sgtcoolguy Added |
|
ios/Classes/TiIdentityModule.m
Outdated
@@ -274,5 +274,9 @@ - (NSDictionary *)deviceCanAuthenticate:(id)unused | |||
|
|||
MAKE_SYSTEM_PROP(AUTHENTICATION_POLICY_BIOMETRICS, LAPolicyDeviceOwnerAuthenticationWithBiometrics); | |||
MAKE_SYSTEM_PROP(AUTHENTICATION_POLICY_PASSCODE, LAPolicyDeviceOwnerAuthentication); | |||
#ifdef __IPHONE_13_0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be like #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 130000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed.
JIRA: https://jira.appcelerator.org/browse/MOD-2532