Bug fix for not updating the header when autoRedirect = false #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! @kazuyukitanimura is there a related JIRA ticket for this issue? |
|
Here is the jira https://jira.appcelerator.org/browse/TC-4483 I can revert the xcode project will do later. Just curious, why did the project got over written? What if we put it in the .gitignore? Is there a better way? How do ppl share git repo over xcode? |
|
yeah, |
|
Removed the problem file |
|
Closing, refer to #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I debugged why autoRedirect property of Ti.Network.createHTTPClient is ignored for 3.3.0.GA. The default property of autoRedirect is true.
When autoRedirect = false is set, self.response.status is always zero in APSHTTPRequest.m
Therefore the redirect check if statement
if (!self.redirects && self.response.status != 0)does always fall through.
[self.response updateResponseParamaters:response];needs to be called in advance