Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-17573] iOS:Allow Set Multiple Cookies in Request Header #23

Closed
wants to merge 1 commit into from
Closed

[TIMOB-17573] iOS:Allow Set Multiple Cookies in Request Header #23

wants to merge 1 commit into from

Conversation

cheekiatng
Copy link
Contributor

@pec1985
Copy link
Contributor

pec1985 commented May 8, 2015

We cannot accept this PR. While it does solve the "bug", it does not solve the problem.
This function is called from the Titanium SDK method setRequestHeader, which means that it sets a header, not add more if exists.
The correct fix would be to expose another method in Titanium called addRequestHeader or something similar (which sets if not exists, or adds if it does), and not only do this for cookies, for anything other harder type. Also, let's not forget about our Android sdk.

PR Rejected.

@cheekiatng cheekiatng closed this May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cheekiatng @pec1985