[TIMOB-25744] iOS: Fix http post data leak #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vijaysingh-axway We likely need to do the same for your NSURLSession change. |
|
@vijaysingh-axway Ping on the review! |
vijaysingh-axway
suggested changes
Mar 8, 2018
| @@ -413,6 +413,8 @@ - (void)responseFinished | |||
| [self invokeCallbackWithState:APSHTTPCallbackStateDataStream]; | |||
|
|
|||
| [self invokeCallbackWithState:APSHTTPCallbackStateLoad]; | |||
|
|
|||
| [[self postForm] destroyTemporaryData]; | |||
There was a problem hiding this comment.
This line should be added in error block of
"- (void)URLSession:(nonnull NSURLSession *)session task:(nonnull NSURLSessionTask *)task didCompleteWithError:(nullable NSError *)error".
There was a problem hiding this comment.
Mhh, it is already. But it should also be here to be used on successful POST requests. Or do you have objections there?
There was a problem hiding this comment.
This is fine here. But in following section also it should be there. Reason is function get return from error block, if error happens.
- (void)URLSession:(nonnull NSURLSession *)session task:(nonnull NSURLSessionTask *)task didCompleteWithError:(nullable NSError *)error
{
if (error != NULL) {
DebugLog(@"%s", __PRETTY_FUNCTION__);
self.response.readyState = APSHTTPResponseStateDone;
[self invokeCallbackWithState:APSHTTPCallbackStateReadyState];
self.response.connected = NO;
self.response.error = error;
[self invokeCallbackWithState:APSHTTPCallbackStateError];
return;
}
|
@vijaysingh-axway PR updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25744