Bring in lodash.mergeWith, use to merge the babel plugins #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brentonhouse, have you try this out? Does it fit your needs? |
feons
approved these changes
Oct 10, 2017
|
This should become obsolete once #842 is merged I think? |
|
From discussions we believe the use case this aimed to achieve to now be possible, so I'm going to close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24980
Bring in lodash.mergewith (from npm package for this specific method), use to merge the babel plugins used to transform the code.
I think this may need some user testing, specifically from @brentonhouse to see if this even will achieve what he's after. plugin and preset ordering has meaning for babel, so it may be difficult to properly allow users to add their own (because they may need to run before or after our own plugins do modifications to the code). This PR only is trying to use the deep merge, not actually add an official config key/value pair for babel plugins (yet).