[TIMOB-25269] iOS: Add iPhone X screenshots #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feons
approved these changes
Sep 18, 2017
|
@feons Should I file an own Alloy Ticket for the CI? Still not sure how the Alloy CI magic works 😙. |
|
@hansemannn, we can track this through existing TIMOB ticket. For CI magic, as as all other CLI modules, you'll need to bump package.json version. |
|
Ok. So per semantic versioning, it would be 1.11.0, but could we actually deliver that latest with SDK 6.3.0 / CLI 6.x ? |
|
@hansemannn, I think so. Just bumped CLI to 6.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25269
To be required in SDK 6.3.0+