[ALOY-1584] Android: Ti.UI.Toolbar has no click event #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feons
reviewed
Oct 17, 2017
| @@ -16,7 +16,7 @@ exports.parse = function(node, state) { | |||
| code = '', | |||
| xmlStyles = {}; | |||
| // Properties inherited from ActionBar when Toolbar is passed to the Activity | |||
| var inheritedProperties = ['backgroundImage', 'displayHomeAsUp', 'homeButtonEnabled', 'navigationMode', 'onHomeItemSelected']; | |||
| var inheritedProperties = [CONST.BACKGROUND_IMAGE, CONST.DISPLAY_HOME_AS_UP, CONST.HOME_BUTTON_ENABLED, CONST.NAVIGATION_MODE, CONST.ON_HOME_ICON_ITEM_SELECTED]; | |||
|
@ypbnv, please add a test app for this. |
|
@feons Updated PR. I am not sure if these two files would be sufficient as test app, so if something else is needed - let me know. |
hansemannn
changed the title
|
@ypbnv, in your Alloy repo folder you can use the command |
|
@ypbnv, please move |
|
Tests passed locally. Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/ALOY-1584
Description:
'onHomeIconItemsSelected ' was not properly inherited from ActionBar when used from Toolbar.
Properties of ActionBar shared between both components are now extracted as constants to avoid future mismatching.
Test case:
In JIRA ticket.