Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync adapters argument order to match Backbone. #86

Closed
wants to merge 1 commit into from

Conversation

davidyang
Copy link

  • Fix all the included sync adapters and change the alloy.js call.

- Fix all the included sync adapters and change the alloy.js call.
@davidyang
Copy link
Author

Hi Tony, this commit will break other people's adapters but I think in the end it's better for the community. It's really confusing to build your own adapter when you have to mismatch the order from Backbone.

@tonylukasavage
Copy link
Contributor

I'm going to leave this open for now. Since this would be a breaking change for others' adapters, I want to make sure we communicate a change like this correctly, and do it on a significant version change, like 0.4.0 or 0.5.0.

@tonylukasavage
Copy link
Contributor

FYI, I created an Alloy ticket for this and hope to get to it in the next week or so: https://jira.appcelerator.org/browse/ALOY-457

@tonylukasavage
Copy link
Contributor

Handled in ALOY-457 as part of an overhaul on sync adapters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants