[ALOY-1609] Add plugins/ti.alloy to gitignore #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
approved these changes
Mar 7, 2018
There was a problem hiding this comment.
Thanks for doing this! @feons are you okay with this change?
ewanharris
reviewed
Mar 7, 2018
Alloy/template/gitignore.txt
Outdated
| @@ -10,3 +10,4 @@ tmp | |||
| .project | |||
| .settings | |||
| Thumbs.db | |||
| plugins/ti.alloy/hooks/alloy.js | |||
There was a problem hiding this comment.
I think we'd want to ignore plugins/ti.alloy and not the specific file? There's a couple other files under there that can change (hooks/readme, hooks/deepclean.js, plugin.py)
There was a problem hiding this comment.
yep that actually makes more sense! Will update the PR
hansemannn
changed the title
feons
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/ALOY-1609
Every time the alloy version changes, the alloy.js plugin file inside the plugin folder changes too. This pollutes git and a default procedure is to remove the file from git alltogether.