[TIMOB-26403] Explicitly expose Alloy, _, and Backbone off the global object when it's available #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obal object when it's available. We intend to remove implicit globals via app.js top-level variables in the future.
feons
reviewed
Oct 2, 2018
| */ | ||
| var Alloy = require('/alloy'), | ||
| var Alloy = require('/alloy'); | ||
| _ = Alloy._, | ||
| Backbone = Alloy.Backbone; |
There was a problem hiding this comment.
Why declare _ and Backbone without var?
|
Closed in favor of #911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26403
Description:
This modifies the
app.jstemplate so that we don't simply declareAlloy,_, andBackboneas top-level variables, we also explicitly assign them as properties offglobalwhen there is aglobal.We intend to remove exposing top-level app.js variables as implicit globals in the future (SDK 9?).