Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for WPATH() in Alloy XML attributes #948

Merged
merged 8 commits into from Apr 27, 2020
Merged

feat: add support for WPATH() in Alloy XML attributes #948

merged 8 commits into from Apr 27, 2020

Conversation

brentonhouse
Copy link
Contributor

No description provided.

@brentonhouse brentonhouse self-assigned this Dec 16, 2019
@build
Copy link

build commented Dec 16, 2019 •
edited

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header
Messages
📖

✅ All tests are passing
Nice one! All 3490 tests are passing.

Generated by 🚫 dangerJS against bfcdae7

ewanharris
ewanharris requested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WPATH in XML attributes change looks good to me.

Could we revert ad243f7 and leave that to be dealt with in #951

ewanharris
ewanharris approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the changes in ad243f7, will merge when CI is done

@ewanharris ewanharris changed the title [ALOY-1253] - Add support for WPATH() in Alloy XML attributes feat: add support for WPATH() in Alloy XML attributes Apr 27, 2020
@ewanharris ewanharris merged commit ac742a1 into tidev:master Apr 27, 2020
@janvennemann janvennemann mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

@feons feons Awaiting requested review from feons

Assignees

@brentonhouse brentonhouse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brentonhouse @build @ewanharris