Fixing vendors #1778

bquenin · 2017-12-02T04:21:59Z

Fix https://techweb.axway.com/jira/browse/AMP-98

This PR fixes vendor (again).

The version for each dependency has been fixed so that we're less vulnerable to any transitive dependency update.
The code has been updated to comply with the new dependencies.

How to test

Make sure you have the latest release version of dep (0.3.2):

$ dep version
dep:
 version     : v0.3.2
 build date  : 2017-10-19
 git hash    : 8ddfc8a
 go version  : go1.9
 go compiler : gc
 platform    : linux/amd64

Test with the following instructions:

$ rm -rf Gopkg.lock vendor
$ dep ensure
$ dep prune

Note that your vendor folder may differ from the one committed on this branch. It's probably because transitive dependencies might have been updated in the meantime. For more details on how dep works, please read https://github.com/golang/dep/blob/master/docs/FAQ.md#how-do-i-constrain-a-transitive-dependencys-version

Then make sure the code compiles and tests as expected:

$ ampmake clean build
$ amp cluster create
$ export PATH=tests/cli/testing:$PATH
$ TESTINCLUDE=tests/cli/testing testrunner tests/cli
$ docker run -it --rm --network core -v $PWD:/go/src/github.com/appcelerator/amp -w /go/src/github.com/appcelerator/amp appcelerator/amptools go test github.com/appcelerator/amp/tests/integration/...

Check Travis build.

ndegory

with latest version of dep. I would expect that dep ensure (without removing the lock file) would recreate the same vendor folder content.

$ rm -rf vendor
$ dep ensure
ensure Solve(): No versions of github.com/opencontainers/runc met constraints:
	v0.1.1: Could not introduce github.com/opencontainers/runc@v0.1.1 due to a case-only variation: it depends on "github.com/Sirupsen/logrus", but "github.com/sirupsen/logrus" was already established as the case variant for that project root by the following other dependers:
	(root)
	github.com/docker/distribution@edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c

	v0.1.0: Could not introduce github.com/opencontainers/runc@v0.1.0, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.9: Could not introduce github.com/opencontainers/runc@v0.0.9, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.8: Could not introduce github.com/opencontainers/runc@v0.0.8, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.7: Could not introduce github.com/opencontainers/runc@v0.0.7, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.6: Could not introduce github.com/opencontainers/runc@v0.0.6, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.5: Could not introduce github.com/opencontainers/runc@v0.0.5, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.4: Could not introduce github.com/opencontainers/runc@v0.0.4, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.3: Could not introduce github.com/opencontainers/runc@v0.0.3, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.2: Could not introduce github.com/opencontainers/runc@v0.0.2, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.1: Could not introduce github.com/opencontainers/runc@v0.0.1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc4: Could not introduce github.com/opencontainers/runc@v1.0.0-rc4, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc3: Could not introduce github.com/opencontainers/runc@v1.0.0-rc3, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc2: Could not introduce github.com/opencontainers/runc@v1.0.0-rc2, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc1: Could not introduce github.com/opencontainers/runc@v1.0.0-rc1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	master: Could not introduce github.com/opencontainers/runc@master, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	fs-named-cgroup: Could not introduce github.com/opencontainers/runc@fs-named-cgroup, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	relabel_fix_docker_1.9.1: Could not introduce github.com/opencontainers/runc@relabel_fix_docker_1.9.1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	resource-hf: Could not introduce github.com/opencontainers/runc@resource-hf, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.2.1: Could not introduce github.com/opencontainers/runc@v0.0.2.1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.

neha-viswanathan

LGTM. Tested on Mac.

neha-viswanathan · 2017-12-06T00:56:11Z

I don't find this discrepancy. I followed the test steps described in the PR as well as tried the steps by @ndegory.

$ rm -rf vendor
$ dep ensure

ndegory · 2017-12-06T01:26:38Z

I've tested on Mac with different versions of dep, same result:

dep from brew
dep from go get (master)
latest release (v0.3.2)

@neha-viswanathan can you please do the test again with:
rm -rf vendor
git checkout -- Gopkg.lock Gopkg.toml
dep ensure

neha-viswanathan · 2017-12-06T01:47:43Z

@ndegory tested with the steps you suggested. I don't see any errors.

bquenin · 2017-12-06T02:21:42Z

@ndegory I couldn't reproduce this issue either. Can you please:

make sure you're using version 0.3.2
clean your dep cache and retry?

$ rm -rf $GOPATH/pkg/dep

ndegory · 2017-12-06T02:34:02Z

~/Development/src/github.com/appcelerator/amp(vendor ✗) rm -rf $GOPATH/pkg/dep
~/Development/src/github.com/appcelerator/amp(vendor ✗) $GOPATH/bin/dep-darwin-amd64 version
dep:
 version     : v0.3.2
 build date  : 2017-10-19
 git hash    : 8ddfc8a
 go version  : go1.9
 go compiler : gc
 platform    : darwin/amd64
~/Development/src/github.com/appcelerator/amp(vendor ✗) $GOPATH/bin/dep-darwin-amd64 ensure
ensure Solve(): No versions of github.com/opencontainers/runc met constraints:
	v0.1.1: Could not introduce github.com/opencontainers/runc@v0.1.1 due to a case-only variation: it depends on "github.com/Sirupsen/logrus", but "github.com/sirupsen/logrus" was already established as the case variant for that project root by the following other dependers:
	(root)
	github.com/docker/distribution@edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c
	github.com/bshuster-repo/logrus-logstash-hook@0.4

	v0.1.0: Could not introduce github.com/opencontainers/runc@v0.1.0, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.9: Could not introduce github.com/opencontainers/runc@v0.0.9, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.8: Could not introduce github.com/opencontainers/runc@v0.0.8, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.7: Could not introduce github.com/opencontainers/runc@v0.0.7, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.6: Could not introduce github.com/opencontainers/runc@v0.0.6, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.5: Could not introduce github.com/opencontainers/runc@v0.0.5, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.4: Could not introduce github.com/opencontainers/runc@v0.0.4, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.3: Could not introduce github.com/opencontainers/runc@v0.0.3, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.2: Could not introduce github.com/opencontainers/runc@v0.0.2, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.1: Could not introduce github.com/opencontainers/runc@v0.0.1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc4: Could not introduce github.com/opencontainers/runc@v1.0.0-rc4, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc3: Could not introduce github.com/opencontainers/runc@v1.0.0-rc3, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc2: Could not introduce github.com/opencontainers/runc@v1.0.0-rc2, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v1.0.0-rc1: Could not introduce github.com/opencontainers/runc@v1.0.0-rc1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	master: Could not introduce github.com/opencontainers/runc@master, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	fs-named-cgroup: Could not introduce github.com/opencontainers/runc@fs-named-cgroup, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	relabel_fix_docker_1.9.1: Could not introduce github.com/opencontainers/runc@relabel_fix_docker_1.9.1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	resource-hf: Could not introduce github.com/opencontainers/runc@resource-hf, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
	v0.0.2.1: Could not introduce github.com/opencontainers/runc@v0.0.2.1, as it is not allowed by constraint 0.1.1 from project github.com/appcelerator/amp.
~/Development/src/github.com/appcelerator/amp(vendor ✗)

bquenin · 2017-12-06T03:03:13Z

There are no occurrences of github.com/Sirupsen/logrus (Uppercase 'S') in the repository, so it must come from somewhere else in your $GOPATH.

Can you please run these commands in your $GOPATH/src :

$ cd $GOPATH/src
$ find . -type f -name '*.go' -not -path '*vendor*' -exec grep -l 'github.com/Sirupsen/logrus' {} \;
$ find . -type f -name '*.go' -not -path '*vendor*' -exec grep -l 'github.com/sirupsen/logrus' {} \;
./github.com/appcelerator/amp/cmd/gateway/main.go
./github.com/appcelerator/amp/cmd/agent/main.go
./github.com/appcelerator/amp/cmd/amplifier/server/configuration/configuration.go
./github.com/appcelerator/amp/cmd/amplifier/server/server.go
./github.com/appcelerator/amp/cmd/amplifier/main.go
./github.com/appcelerator/amp/pkg/docker/service.go
./github.com/appcelerator/amp/pkg/docker/stack.go
./github.com/appcelerator/amp/pkg/cloud/aws/aws.go
./github.com/appcelerator/amp/pkg/cloud/provider.go
./github.com/appcelerator/amp/pkg/nats-streaming/nats-streaming.go
./github.com/appcelerator/amp/api/rpc/cluster/cluster.go
./github.com/appcelerator/amp/api/rpc/config/config.go
./github.com/appcelerator/amp/api/rpc/resource/resource.go
./github.com/appcelerator/amp/api/rpc/account/account.go
./github.com/appcelerator/amp/api/rpc/secret/secret.go
./github.com/appcelerator/amp/api/rpc/logs/logs.go
./github.com/appcelerator/amp/api/rpc/service/service.go
./github.com/appcelerator/amp/api/rpc/stack/stack.go
./github.com/appcelerator/amp/api/rpc/object_store/object_store.go
./github.com/appcelerator/amp/agent/api.go
./github.com/appcelerator/amp/agent/config.go
./github.com/appcelerator/amp/agent/agent.go
./github.com/appcelerator/amp/agent/logs.go
./github.com/appcelerator/amp/agent/container.go
./github.com/appcelerator/amp/docker/cli/cli/flags/common.go
./github.com/appcelerator/amp/docker/cli/cli/compose/loader/loader.go
./github.com/appcelerator/amp/docker/cli/cli/command/out.go
./github.com/appcelerator/amp/docker/cli/cli/command/events_utils.go
./github.com/appcelerator/amp/docker/cli/cli/command/inspect/inspector.go
./github.com/appcelerator/amp/docker/docker/pkg/term/windows/windows.go
./github.com/appcelerator/amp/docker/docker/pkg/system/syscall_windows.go
./github.com/appcelerator/amp/docker/docker/registry/config.go
./github.com/appcelerator/amp/docker/docker/registry/service.go
./github.com/appcelerator/amp/docker/docker/registry/auth.go
./github.com/appcelerator/amp/docker/docker/registry/resumable/resumablerequestreader.go
./github.com/appcelerator/amp/docker/docker/registry/registry.go
./github.com/appcelerator/amp/docker/docker/registry/session.go
./github.com/appcelerator/amp/docker/docker/registry/endpoint_v1.go
./github.com/appcelerator/amp/data/accounts/authz.go
./github.com/appcelerator/amp/data/accounts/store.go
./github.com/appcelerator/amp/data/storage/etcd/store.go
./github.com/appcelerator/amp/data/storage/etcd/watcher.go

ndegory · 2017-12-06T04:05:27Z

If my other projects' vendors impact what happens in amp, we're in trouble. I have indeed a few projects using a different case:

ag -sl 'github.com/Sirupsen/logrus' -G .go$ .
gopkg.in/dancannon/gorethink.v1/gorethink.go
gopkg.in/dancannon/gorethink.v1/cluster.go
github.com/docker/infrakit.docker-metadata/cmd/main.go
github.com/docker/infrakit.docker-metadata/template.go
github.com/docker/infrakit/cmd/group/main.go
github.com/docker/infrakit/cmd/resource/main.go
github.com/docker/infrakit/examples/flavor/zookeeper/main.go
github.com/docker/infrakit/vendor/gopkg.in/inconshreveable/log15.v2/doc.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/archive/changes.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/archive/copy.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/archive/diff.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/archive/archive.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/archive/example_changes.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/system/syscall_windows.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/fileutils/fileutils_unix.go
github.com/docker/infrakit/vendor/github.com/docker/docker/pkg/fileutils/fileutils.go
github.com/docker/infrakit/vendor/github.com/docker/go-connections/sockets/unix_socket.go
github.com/docker/infrakit/vendor/github.com/docker/go-connections/tlsconfig/config.go
github.com/docker/infrakit/vendor/github.com/docker/go-connections/tlsconfig/certpool_other.go
github.com/docker/infrakit/vendor/github.com/docker/go-connections/tlsconfig/certpool_go17.go
github.com/docker/infrakit/vendor/github.com/Sirupsen/logrus/json_formatter.go
github.com/docker/infrakit/vendor/github.com/Sirupsen/logrus/doc.go
github.com/docker/infrakit/vendor/github.com/thebsdbox/go-tftp/server/readreq.go
github.com/docker/infrakit/vendor/github.com/thebsdbox/go-tftp/server/server.go
github.com/docker/infrakit/vendor/github.com/thebsdbox/go-tftp/server/writereq.go
github.com/docker/infrakit/pkg/broker/server/sse.go
github.com/docker/infrakit/pkg/broker/server/interceptor.go
github.com/docker/infrakit/pkg/util/docker/docker.go
github.com/docker/infrakit/pkg/launch/os/os_windows.go
github.com/docker/infrakit/pkg/launch/os/os_unix.go
github.com/docker/infrakit/pkg/plugin/instance/file/plugin.go
github.com/docker/infrakit/pkg/plugin/resource/plugin.go
github.com/docker/infrakit/pkg/provider/terraform/instance/cmd/main.go
github.com/docker/infrakit/pkg/provider/terraform/instance/plugin.go
github.com/docker/infrakit/pkg/provider/terraform/instance/apply.go
github.com/docker/infrakit/pkg/provider/ibmcloud/plugin/instance/volumeauthplugin.go
github.com/docker/infrakit/pkg/provider/docker/plugin/instance/instance.go
github.com/docker/infrakit/pkg/provider/vagrant/plugin/instance/instance.go
github.com/docker/infrakit/pkg/provider/google/plugin/group/plugin.go
github.com/docker/infrakit/pkg/provider/google/plugin/metadata/plugin.go
github.com/docker/infrakit/pkg/provider/digitalocean/plugin/instance/plugin.go
github.com/docker/infrakit/pkg/provider/oracle/client/core/subnet.go
github.com/docker/infrakit/pkg/provider/oracle/client/core/instance.go
github.com/docker/infrakit/pkg/provider/oracle/client/core/virtual_nic_attachment.go
github.com/docker/infrakit/pkg/provider/oracle/client/core/virtual_nic.go
github.com/docker/infrakit/pkg/provider/oracle/client/core/security_list.go
github.com/docker/infrakit/pkg/provider/oracle/client/core/virtual_network.go
github.com/docker/infrakit/pkg/provider/oracle/client/loadbalancer/certificate.go
github.com/docker/infrakit/pkg/provider/oracle/client/loadbalancer/backend.go
github.com/docker/infrakit/pkg/provider/oracle/client/loadbalancer/load_balancer.go
github.com/docker/infrakit/pkg/provider/oracle/client/loadbalancer/health_checker.go
github.com/docker/infrakit/pkg/provider/oracle/client/loadbalancer/backend_set.go
github.com/docker/infrakit/pkg/provider/oracle/client/loadbalancer/listener.go
github.com/docker/infrakit/pkg/provider/oracle/client/api/http_client.go
github.com/docker/infrakit/pkg/provider/oracle/client/api/client.go
github.com/docker/infrakit/pkg/provider/oracle/client/bmc/error.go
github.com/docker/infrakit/pkg/provider/oracle/client/bmc/config.go
github.com/docker/infrakit/pkg/provider/libvirt/plugin/instance/instance.go
github.com/docker/infrakit/pkg/provider/aws/experimental/bootstrap/cmd/infrakitctl/main.go
github.com/docker/infrakit/pkg/provider/aws/experimental/bootstrap/destroy.go
github.com/docker/infrakit/pkg/provider/aws/experimental/bootstrap/create.go
github.com/docker/infrakit/pkg/provider/aws/experimental/bootstrap/cli.go
github.com/docker/infrakit/pkg/provider/aws/experimental/bootstrap/formatter.go
github.com/docker/infrakit/pkg/provider/aws/plugin/loadbalancer/elb.go
github.com/docker/infrakit/pkg/provider/aws/plugin/instance/monitor.go
github.com/docker/infrakit/pkg/provider/aws/plugin/instance/autoscaling_autoscalinggroup.go
github.com/docker/infrakit/pkg/provider/aws/plugin/instance/ec2_spot_instance.go
github.com/docker/infrakit/pkg/provider/aws/plugin/instance/ec2_instance.go
github.com/docker/infrakit/pkg/provider/rackhd/plugin/instance/cmd/main.go
github.com/docker/infrakit/pkg/provider/rackhd/plugin/instance/instance.go
github.com/docker/infrakit/pkg/cli/logging.go
github.com/docker/infrakit/pkg/log/log.go
github.com/docker/infrakit/pkg/rpc/event/client.go
github.com/docker/infrakit/pkg/store/swarm/swarm.go
github.com/golang/dep/gps/solve_bimodal_test.go
github.com/LK4D4/vndr/test/testdata/dumbproject/pkg1/pkg.go
github.com/grafana/grafana/vendor/github.com/inconshreveable/log15/doc.go
github.com/rancher/trash/trash_test.go
github.com/rancher/trash/util/util.go
github.com/rancher/trash/trash.go
github.com/rancher/trash/conf/conf.go
github.com/rancher/trash/vendor/github.com/Sirupsen/logrus/json_formatter.go
github.com/rancher/trash/vendor/github.com/Sirupsen/logrus/doc.go

ag -sl 'github.com/sirupsen/logrus' -G .go$ .
github.com/appcelerator/amp/cmd/amplifier/server/configuration/configuration.go
github.com/appcelerator/amp/cmd/amplifier/server/server.go
github.com/appcelerator/amp/cmd/amplifier/main.go
github.com/appcelerator/amp/cmd/agent/main.go
github.com/appcelerator/amp/cmd/gateway/main.go
github.com/appcelerator/amp/docker/docker/registry/config.go
github.com/appcelerator/amp/docker/docker/registry/service.go
github.com/appcelerator/amp/docker/docker/registry/auth.go
github.com/appcelerator/amp/docker/docker/registry/session.go
github.com/appcelerator/amp/docker/docker/registry/registry.go
github.com/appcelerator/amp/docker/docker/registry/resumable/resumablerequestreader.go
github.com/appcelerator/amp/docker/docker/registry/endpoint_v1.go
github.com/appcelerator/amp/docker/docker/pkg/term/windows/windows.go
github.com/appcelerator/amp/docker/docker/pkg/system/syscall_windows.go
github.com/appcelerator/amp/docker/cli/cli/flags/common.go
github.com/appcelerator/amp/docker/cli/cli/compose/loader/loader.go
github.com/appcelerator/amp/docker/cli/cli/command/events_utils.go
github.com/appcelerator/amp/docker/cli/cli/command/inspect/inspector.go
github.com/appcelerator/amp/docker/cli/cli/command/out.go
github.com/appcelerator/amp/agent/config.go
github.com/appcelerator/amp/agent/api.go
github.com/appcelerator/amp/agent/logs.go
github.com/appcelerator/amp/agent/agent.go
github.com/appcelerator/amp/agent/container.go
github.com/appcelerator/amp/api/rpc/cluster/cluster.go
github.com/appcelerator/amp/api/rpc/object_store/object_store.go
github.com/appcelerator/amp/api/rpc/config/config.go
github.com/appcelerator/amp/api/rpc/logs/logs.go
github.com/appcelerator/amp/api/rpc/secret/secret.go
github.com/appcelerator/amp/api/rpc/stack/stack.go
github.com/appcelerator/amp/api/rpc/account/account.go
github.com/appcelerator/amp/api/rpc/service/service.go
github.com/appcelerator/amp/api/rpc/resource/resource.go
github.com/appcelerator/amp/data/storage/etcd/store.go
github.com/appcelerator/amp/data/storage/etcd/watcher.go
github.com/appcelerator/amp/data/accounts/store.go
github.com/appcelerator/amp/data/accounts/authz.go
github.com/appcelerator/amp/pkg/docker/service.go
github.com/appcelerator/amp/pkg/docker/stack.go
github.com/appcelerator/amp/pkg/nats-streaming/nats-streaming.go
github.com/appcelerator/amp/pkg/cloud/provider.go
github.com/appcelerator/amp/pkg/cloud/aws/aws.go
github.com/golang/dep/gps/solve_bimodal_test.go
github.com/golang/dep/gps/vcs_version_test.go
github.com/golang/dep/gps/manager_test.go
github.com/golang/dep/gps/solve_failures.go

ndegory · 2017-12-06T04:06:42Z

makes me think we should add dep in our gotools image and run it with ampmake to avoid any environmental impact.

bquenin · 2017-12-06T19:01:10Z

@ndegory yeah, adding dep to our build tools could fix your issue. Please open a ticket.

ndegory · 2017-12-11T19:32:58Z

now that the branch is rebased on master with the ampmake target for vendor installation, I still have the issue:
(vendor ✗) rm -rf $GOPATH/pkg/
(vendor ✗) mkdir $GOPATH/pkg/
(vendor ✗) ampmake install-vendor
Using existing GOPATH: REDACTED
ensure Solve(): No versions of github.com/docker/distribution met constraints:
edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c: Could not introduce github.com/docker/distribution@edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c due to a case-only variation: it depends on "github.com/sirupsen/logrus", but "github.com/Sirupsen/logrus" was already established as the case variant for that project root by depender (root)
v2.6.2: Could not introduce github.com/docker/distribution@v2.6.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.6.1: Could not introduce github.com/docker/distribution@v2.6.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.6.0: Could not introduce github.com/docker/distribution@v2.6.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.5.2: Could not introduce github.com/docker/distribution@v2.5.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.5.1: Could not introduce github.com/docker/distribution@v2.5.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.5.0: Could not introduce github.com/docker/distribution@v2.5.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.4.1: Could not introduce github.com/docker/distribution@v2.4.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.4.0: Could not introduce github.com/docker/distribution@v2.4.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.3.1: Could not introduce github.com/docker/distribution@v2.3.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.3.0: Could not introduce github.com/docker/distribution@v2.3.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.2.1: Could not introduce github.com/docker/distribution@v2.2.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.2.0: Could not introduce github.com/docker/distribution@v2.2.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.1.1: Could not introduce github.com/docker/distribution@v2.1.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.1.0: Could not introduce github.com/docker/distribution@v2.1.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.1: Could not introduce github.com/docker/distribution@v2.0.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0: Could not introduce github.com/docker/distribution@v2.0.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.6.1-rc.2: Could not introduce github.com/docker/distribution@v2.6.1-rc.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.6.1-rc.1: Could not introduce github.com/docker/distribution@v2.6.1-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.6.0-rc.2: Could not introduce github.com/docker/distribution@v2.6.0-rc.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.6.0-rc.1: Could not introduce github.com/docker/distribution@v2.6.0-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.5.1-rc.1: Could not introduce github.com/docker/distribution@v2.5.1-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.5.0-rc.2: Could not introduce github.com/docker/distribution@v2.5.0-rc.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.5.0-rc.1: Could not introduce github.com/docker/distribution@v2.5.0-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.4.1-rc.2: Could not introduce github.com/docker/distribution@v2.4.1-rc.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.4.1-rc.1: Could not introduce github.com/docker/distribution@v2.4.1-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.4.1-rc.0: Could not introduce github.com/docker/distribution@v2.4.1-rc.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.4.0-rc.1: Could not introduce github.com/docker/distribution@v2.4.0-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.4.0-rc.0: Could not introduce github.com/docker/distribution@v2.4.0-rc.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.3.1-rc.0: Could not introduce github.com/docker/distribution@v2.3.1-rc.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.3.0-rc.2: Could not introduce github.com/docker/distribution@v2.3.0-rc.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.3.0-rc.1: Could not introduce github.com/docker/distribution@v2.3.0-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.3.0-rc.0: Could not introduce github.com/docker/distribution@v2.3.0-rc.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.3.0-alpha: Could not introduce github.com/docker/distribution@v2.3.0-alpha, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.1.0-rc.0: Could not introduce github.com/docker/distribution@v2.1.0-rc.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-rc.4: Could not introduce github.com/docker/distribution@v2.0.0-rc.4, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-rc.3: Could not introduce github.com/docker/distribution@v2.0.0-rc.3, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-rc.2: Could not introduce github.com/docker/distribution@v2.0.0-rc.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-rc.1: Could not introduce github.com/docker/distribution@v2.0.0-rc.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-rc.0: Could not introduce github.com/docker/distribution@v2.0.0-rc.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-alpha.3: Could not introduce github.com/docker/distribution@v2.0.0-alpha.3, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-alpha.2: Could not introduce github.com/docker/distribution@v2.0.0-alpha.2, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-alpha.1: Could not introduce github.com/docker/distribution@v2.0.0-alpha.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
v2.0.0-alpha.0: Could not introduce github.com/docker/distribution@v2.0.0-alpha.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
master: Could not introduce github.com/docker/distribution@master, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
aws-vendor-update: Could not introduce github.com/docker/distribution@aws-vendor-update, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docker/1.10: Could not introduce github.com/docker/distribution@docker/1.10, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docker/1.10-dev: Could not introduce github.com/docker/distribution@docker/1.10-dev, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docker/1.13: Could not introduce github.com/docker/distribution@docker/1.13, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docker/1.8: Could not introduce github.com/docker/distribution@docker/1.8, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docker/1.9: Could not introduce github.com/docker/distribution@docker/1.9, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
feature_dyn_plugin: Could not introduce github.com/docker/distribution@feature_dyn_plugin, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
release/2.0: Could not introduce github.com/docker/distribution@release/2.0, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
release/2.0-image-validation-stopgap: Could not introduce github.com/docker/distribution@release/2.0-image-validation-stopgap, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
release/2.1: Could not introduce github.com/docker/distribution@release/2.1, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
release/2.3: Could not introduce github.com/docker/distribution@release/2.3, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
release/2.4: Could not introduce github.com/docker/distribution@release/2.4, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
release/2.5: Could not introduce github.com/docker/distribution@release/2.5, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
release/2.6: Could not introduce github.com/docker/distribution@release/2.6, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
test-go-1.8-rc: Could not introduce github.com/docker/distribution@test-go-1.8-rc, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docs-v2.4.1-2016-06-01: Could not introduce github.com/docker/distribution@docs-v2.4.1-2016-06-01, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docs-v2.4.1-2016-06-28: Could not introduce github.com/docker/distribution@docs-v2.4.1-2016-06-28, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
docs-v2.5.0-2016-07-28: Could not introduce github.com/docker/distribution@docs-v2.5.0-2016-07-28, as it is not allowed by constraint edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c from project docker.io/go-docker.
make: *** [Makefile:82: install-vendor] Error 1

ndegory · 2017-12-12T16:57:07Z

Working great now with the --vendor-only.

bquenin changed the title ~~ixing vendors~~ Fixing vendors Dec 2, 2017

bquenin mentioned this pull request Dec 4, 2017

Fix cloudfoundry/bytefmt vendoring #1772

Closed

ndegory suggested changes Dec 6, 2017

View reviewed changes

neha-viswanathan previously approved these changes Dec 6, 2017

View reviewed changes

bquenin dismissed neha-viswanathan’s stale review via fd7eae8 December 11, 2017 21:54

bquenin force-pushed the vendor branch from ab5d602 to fd7eae8 Compare December 11, 2017 21:54

fixing vendors

bf565a6

bquenin force-pushed the vendor branch from fd7eae8 to bf565a6 Compare December 11, 2017 22:37

ndegory approved these changes Dec 12, 2017

View reviewed changes

ndegory merged commit 2c16ec0 into master Dec 12, 2017

ndegory deleted the vendor branch December 12, 2017 16:58

ndegory added this to the 0.18.0 milestone Dec 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing vendors #1778

Fixing vendors #1778

bquenin commented Dec 2, 2017 •

edited

ndegory left a comment •

edited

neha-viswanathan left a comment

neha-viswanathan commented Dec 6, 2017

ndegory commented Dec 6, 2017

neha-viswanathan commented Dec 6, 2017

bquenin commented Dec 6, 2017

ndegory commented Dec 6, 2017

bquenin commented Dec 6, 2017 •

edited

ndegory commented Dec 6, 2017

ndegory commented Dec 6, 2017

bquenin commented Dec 6, 2017

ndegory commented Dec 11, 2017

ndegory commented Dec 12, 2017

Fixing vendors #1778

Fixing vendors #1778

Conversation

bquenin commented Dec 2, 2017 • edited

How to test

ndegory left a comment • edited

Choose a reason for hiding this comment

neha-viswanathan left a comment

Choose a reason for hiding this comment

neha-viswanathan commented Dec 6, 2017

ndegory commented Dec 6, 2017

neha-viswanathan commented Dec 6, 2017

bquenin commented Dec 6, 2017

ndegory commented Dec 6, 2017

bquenin commented Dec 6, 2017 • edited

ndegory commented Dec 6, 2017

ndegory commented Dec 6, 2017

bquenin commented Dec 6, 2017

ndegory commented Dec 11, 2017

ndegory commented Dec 12, 2017

bquenin commented Dec 2, 2017 •

edited

ndegory left a comment •

edited

bquenin commented Dec 6, 2017 •

edited