[DAEMON-121] Fix lookup of npm in 32bit Node #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
reviewed
Nov 10, 2017
|
|
||
| try { | ||
| npm = await which(`npm${cmd}`); | ||
| const { stdout } = run(npm, 'prefix', '-g'); | ||
| const { stdout } = await run(npm, [ 'prefix', '-g' ]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/DAEMON-121
This fixes the lookup of npm so that we can find it under a 32 bit Node install on 64 bit Windows.
It also changes the lookup slightly so it is now as follows
npm get prefix$prefix/node_modules/npm/package.json, if it's a file continue on%ProgramFiles%/nodejs/node_modules/npm/package.jsonor/usr/local/node_modules/npm/package.json, if it's a file continue on%ProgramFiles(x86)%/nodejs/node_modules/npm/package.jsonor/usr/local/lib/node_modules/npm/package.jsonThis means that we always prefer the globally installed npm on Windows, (which seems correct to me), one caveat is that the path property of npm points us to the one under node, but that's not a major deal as the npm.cmd file will forward us on to the global npm. We might wish to fix that for correctness 🤷♂️