[DAEMON-241] Fix telemetry guid and add deployType to events #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
requested changes
Mar 9, 2018
docs/Getting-Started.md
Outdated
| @@ -159,6 +159,8 @@ will rebuild that package and all parent packages, then restart the Appc Daemon. | |||
| > malformed JavaScript code, it's likely going to cause `gulp` to exit, but the last spawned Appc | |||
| > Daemon process will remain running. You may need to run `appcd stop` or `killall appcd`. | |||
|
|
|||
| When running the Appc Daemon with the `gulp watch` task telemetry will be sent using the `development` deployType. | |||
cb1kenobi
requested changes
Mar 9, 2018
gulpfile.js
Outdated
| @@ -277,7 +277,7 @@ function runTests(cover, cb) { | |||
| * watch/debug tasks | |||
| */ | |||
| function startDaemon() { | |||
| spawn(process.execPath, [ 'packages/appcd/bin/appcd', 'start', '--debug' ], { stdio: 'inherit' }); | |||
| spawn(process.execPath, [ 'packages/appcd/bin/appcd', 'start', '--debug', '--config', '{ \"telemetry\": { \"deployType\": \"development\" } }' ], { stdio: 'inherit' }); | |||
There was a problem hiding this comment.
s/deployType/environment/
packages/appcd-core/conf/default.js
Outdated
| * Deploy type for the analytics events. | ||
| * @type {String} | ||
| */ | ||
| deployType: 'production', |
There was a problem hiding this comment.
s/deployType/environment/
cb1kenobi
reviewed
Mar 9, 2018
| * The deploy type for the events. | ||
| * @type {String} | ||
| */ | ||
| this.deployType = cfg.get('telemetry.deployType') || 'production'; |
There was a problem hiding this comment.
this.deployType = cfg.get('telemetry.environment') || 'production';
cb1kenobi
reviewed
Mar 9, 2018
packages/appcd-core/conf/default.js
Outdated
| @@ -1,4 +1,8 @@ | |||
| module.exports = { | |||
| environment: { | |||
There was a problem hiding this comment.
Alphabetical order please.
Rename deployType to environment, wrap line
|
@cb1kenobi Updated |
cb1kenobi
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/DAEMON-241