Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAEMON-256] Export CLI definition and update cli-kit #325

Merged
merged 3 commits into from May 16, 2018
Merged

[DAEMON-256] Export CLI definition and update cli-kit #325

merged 3 commits into from May 16, 2018

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi cb1kenobi requested a review from ewanharris May 15, 2018 22:35
ewanharris
ewanharris approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ran through basic sanity tests via appcd and appc appcd on OSX and saw no red flags.

@cb1kenobi Are we gonna publish this as 1.2.0 and be cool with the appc cli picking it up or are we gonna prerelease it?

@ewanharris ewanharris merged commit 23c8527 into tidev:master May 16, 2018
@cb1kenobi cb1kenobi deleted the DAEMON-256 branch May 16, 2018 16:33
@cb1kenobi
Copy link
Contributor Author

I'll publish an appcd@1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cb1kenobi @ewanharris