Fix Genymotion launch script (Genymotion 2.10 and higher) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The help_run.js script doesn't detect when Genymotion is launched at the moment. I have updated the call of fs.createReadStream because it doesn't work with node 6.x and higher + changed the regex to support the new Genymotion log format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I started to use the appium-tests project, I found that the Genymotion emulators launched, but the install of the app was never triggered.
The script was waiting for "Connected" on the last line of the logs, but it does not happen now with the latest Genymotion versions.
Only "Device booted in X ms" can be track and not open the last line because Genymotion emulators log more things after it has booted.