[TIMOB-24198] Force include Foundation framework (2.0.X) #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
requested changes
Jan 31, 2017
metabase/ios/lib/metabase.js
Outdated
| @@ -178,6 +178,16 @@ function generateMetabase (buildDir, sdk, sdkPath, iosMinVersion, includes, excl | |||
| var header = path.join(buildDir, 'metabase-' + iosMinVersion + '-' + sdk + '-' + cacheToken + '.h'); | |||
| var outfile = path.join(buildDir, 'metabase-' + iosMinVersion + '-' + sdk + '-' + cacheToken + '.json'); | |||
|
|
|||
| // Foundation header always needs to be included | |||
| var absoluteFoundationHeaderRegex = /Foundation\.framework\/Headers\/Foundation\.h$/; | |||
| var systemFoundationHeaderRegex = /^[<"]Foundation\/Foundation\.h[<"]$/; | |||
There was a problem hiding this comment.
The regex matches for some incorrect require-statements. Replace at least the latter < with >.
metabase/ios/test/generate_test.js
Outdated
| should(instance.className).be.equal('NSString'); | ||
| should(instance.$native).be.an.object; | ||
|
|
||
| // ... and if INPreferences is genreated correctly, which does not work without |
metabase/ios/test/generate_test.js
Outdated
|
|
||
| // ... and if INPreferences is genreated correctly, which does not work without | ||
| // explicitly including Foundation framework | ||
| var INPreferences = require(nodePath.join(buildDir, 'intents/inpreferences.js')); |
There was a problem hiding this comment.
Do we only run the test with iOS 10+? Otherwise, we need to wrap this out for iOS 9.
There was a problem hiding this comment.
These tests are currently not run by the CI build at all and need to be triggered manually, so you have to make sure to run them with Xcode 8 / iOS 10 selected. Most of them are broken anyway and i'll rework them in a separate PR.
hansemannn
approved these changes
Jan 31, 2017
This was referenced Jan 31, 2017
|
CR + FT passed, PR approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24198
Fixes a metabase parsing issue for headers that do not explicitly include the Foundation framework themselves.
2.0.X backport of #114