[TIMOB-24242] Pass extra header search paths to metabase parser #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes additional header search paths from CocoaPods to the metabase parser so internal includes to other headers within a Pod can be properly resolved.
janvennemann
force-pushed
the
TIMOB-24242
branch
from
dc530a5
to
9a24def
Compare
janvennemann
force-pushed
the
TIMOB-24242
branch
from
45afcb0
to
e9d0ba0
Compare
hansemannn
requested changes
Mar 2, 2017
| if (frameworks.size() > 0) { | ||
| for (auto i = 0; i < frameworks.size(); i++) { | ||
| auto each = frameworks[i]; | ||
| if (each.at(0) == (int)'"') { |
There was a problem hiding this comment.
Can you give me an example of the frameworks array? We should try to avoid doing those string-compares - people can also use ' for the iOS includes
There was a problem hiding this comment.
It's copied from the include step above. It has nothing to do with the import statements but will be generated in https://github.com/appcelerator/hyperloop.next/pull/118/files#diff-ab30ce96af74b6522ec0cbb3a275fc14R227 and is a path. These lines will trim leading and trailing " from that path. For example "/Users/jvennemann/Development/appc/hyperloop-examples/src"
There was a problem hiding this comment.
Thanks, I were at the Framework includes, not the Framework search paths..
hansemannn
approved these changes
Mar 2, 2017
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24242
This passes additional header search paths from CocoaPods to the
metabase parser so internal includes to other headers within a Pod can
be properly resolved.