[TIMOB-23679] Properly detect declaration node

[janvennemann]

JIRA: https://jira.appcelerator.org/browse/TIMOB-23679

This fixes crashes for Hyperloop.defineClass custom classes with minified code e.g. for device builds.

@hansemannn, can you please check with your device? I could only verify it with -T device --build-only and some debugging during the build so far.

[hansemannn]

Unfortunately it's still crashing when selecting a date. Will need to wait until you have your iOS device for more tests.

EDIT: The crash looks different now, might actually be related to an incorrect implementation on the JS-side:

[ERROR] The application has crashed with an uncaught exception 'NSInvalidArgumentException'.
[ERROR] Reason:
[ERROR] *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil
[ERROR] Stack trace:
[ERROR] 0   CoreFoundation                      0x000000018c262fd8 <redacted> + 124
[ERROR] 1   libobjc.A.dylib                     0x000000018acc4538 objc_exception_throw + 56
[ERROR] 2   CoreFoundation                      0x000000018c144888 CFStringConvertNSStringEncodingToEncoding + 0
[ERROR] 3   Hyperloop_Sample                    0x00000001001e6620 Hyperloop_Sample + 1926688
[ERROR] 4   Hyperloop_Sample                    0x00000001001e7c48 Hyperloop_Sample + 1932360
[ERROR] 5   UIKit                               0x00000001925a8fc0 <redacted> + 596
[ERROR] 6   UIKit                               0x00000001925a8954 <redacted> + 584
[ERROR] 7   UIKit                               0x00000001925252c8 <redacted> + 336
[ERROR] 8   UIKit                               0x000000019256f624 <redacted> + 60
[ERROR] 9   UIKit                               0x00000001925252c8 <redacted> + 336
[ERROR] 10  UIKit                               0x000000019256f624 <redacted> + 60
[ERROR] 11  UIKit                               0x00000001925252c8 <redacted> + 336
[ERROR] 12  UIKit                               0x000000019256f624 <redacted> + 60
[ERROR] 13  UIKit                               0x000000019295d930 <redacted> + 4280
[ERROR] 14  UIKit                               0x0000000192959c7c <redacted> + 1128
[ERROR] 15  UIKit                               0x00000001929597c0 <redacted> + 404
[ERROR] 16  UIKit                               0x0000000192958a6c <redacted> + 268
[ERROR] 17  UIKit                               0x00000001923c4b38 <redacted> + 3164
[ERROR] 18  UIKit                               0x0000000192395768 <redacted> + 340
[ERROR] 19  UIKit                               0x0000000192b8e39c <redacted> + 2400
[ERROR] 20  UIKit                               0x0000000192b88af8 <redacted> + 4268
[ERROR] 21  UIKit                               0x0000000192b88f24 <redacted> + 148
[ERROR] 22  CoreFoundation                      0x000000018c211424 <redacted> + 24
[ERROR] 23  CoreFoundation                      0x000000018c210d94 <redacted> + 540
[ERROR] 24  CoreFoundation                      0x000000018c20e9a0 <redacted> + 744
[ERROR] 25  CoreFoundation                      0x000000018c13ed94 CFRunLoopRunSpecific + 424
[ERROR] 26  GraphicsServices                    0x000000018dba8074 GSEventRunModal + 100
[ERROR] 27  UIKit                               0x00000001923fa480 UIApplicationMain + 208
[ERROR] 28  Hyperloop_Sample                    0x0000000100016928 Hyperloop_Sample + 26920
[ERROR] 29  libdyld.dylib                       0x000000018b14d59c <redacted> + 4

[hansemannn]

@janvennemann Should I put out of 2.1.0? Did you receive your device already? You could borrow mine again if required.

[janvennemann]

@hansemannn, my device was shipped today so it will be a few days until it arrives. I'll gonna pick up your's tomorrow if possible and then do some testing with that.

[hansemannn]

Top, komm rum!

[janvennemann]

@hansemannn The fix was successfully verified by Abir, Eric and myself. Neither of us ran into the crash you were seeing.

[hansemannn]

Thanks! Merging then.