[TIMOB-24383] Make sure to use correct prototype for existing wrappers (2_1_X) #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A wrapper object is stored with the prototype it was first created with. Under certain use cases it can happen that the wrapper for a pointer is generated for a less specific type in the inheritance chain like NSObject. All further access to that wrapper would then use the NSObject prototype even if casted to their specific type, rendering all methods and properties from the specific wrapper implementation unusable. This commit fixes that by making sure to always set the correct prototype before returning an existing wrapper instance.
|
@janvennemann Can you update the Hyperloop Beta release with the latest version? I'll check which tickets are included then. |
|
@hansemannn I'll wait till #160 is merged and then draft a new release. Are you ok with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24383
A wrapper object is stored with the prototype it was first created with. Under certain use cases it can happen that the wrapper for a pointer is generated for a less specific type in the inheritance chain like NSObject. All further access to that wrapper would then use the NSObject prototype even if casted to their specific type, rendering all methods and properties from the specific wrapper implementation unusable. This commit fixes that by making sure to always set the correct prototype before returning an existing wrapper instance.