[TIMOB-23899] Add support for open access level keyword #163
Conversation
| @@ -201,6 +201,7 @@ function generateSwiftMetabase (buildDir, sdk, sdkPath, iosMinVersion, xcodeTarg | |||
| componentRE = /component id='(.*)'/, | |||
| patternNamedRE = /pattern_named type='(\w+)' '(\w+)'/, | |||
| typeRE = /type='(\w+)'/, | |||
| publicAccessPattern = /access=(public|open)/, | |||
There was a problem hiding this comment.
How about other accessors? Swift has some unique ones like fileprivate.
There was a problem hiding this comment.
All other access levels are restricted in a certain way and cannot be used from any code that is written in Hyperloop so they can be safely ignored.
| @@ -229,7 +230,7 @@ function generateSwiftMetabase (buildDir, sdk, sdkPath, iosMinVersion, xcodeTarg | |||
| language: 'swift' | |||
| }; | |||
| tok.slice(2).forEach(function (t, i) { | |||
| if (t.indexOf('access=public') === 0) { | |||
| if (publicAccessPattern.test(t)) { | |||
| classdef.public = true; | |||
There was a problem hiding this comment.
An open class is not a public class. Not sure if setting those flags is generic enough to deal with Swift properly.
There was a problem hiding this comment.
True, but the way we use this flag is to determine if a entity can be accessed via Hyperloop and in that case, it doesn't matter if it is public or open. I tried to make as little changes as possible considering we have a huge Swift overhaul coming anyway.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23899