Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25060] Build Android hyperloop against SDK 7.0.0 / v8 5.7+ #179

Merged
merged 5 commits into from Nov 9, 2017
Merged

[TIMOB-25060] Build Android hyperloop against SDK 7.0.0 / v8 5.7+ #179

merged 5 commits into from Nov 9, 2017

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Jun 13, 2017 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-25060

Description
This is to build the android module against SDK 7.0.0's version of V8. Currently that is 5.7, but will likely be 6.0 eventually (relates to tidev/titanium-sdk#9082).

This bumps the major version of the module (android half), bumps the api level, bumps the min SDK.

@sgtcoolguy sgtcoolguy mentioned this pull request Jun 13, 2017
Merged
@sgtcoolguy sgtcoolguy changed the title Bump version, apiversion, build against 6.2.0+ Compile against V8 5.7+: Bump version, apiversion, build against 7.0.0+ Aug 2, 2017
@sgtcoolguy sgtcoolguy changed the title Compile against V8 5.7+: Bump version, apiversion, build against 7.0.0+ [TIMOB-25060] Build Android hyperloop against SDK 7.0.0 / v8 5.7+ Aug 2, 2017
@hansemannn hansemannn added this to the v3.0.0 milestone Aug 8, 2017
@hansemannn
Copy link
Contributor

@sgtcoolguy @garymathews I updated the sdk-level to latest master (v20171025141436) and node to 8.8.1 (latest Node 8.x) to incorporate the coming Node 8+ requirement from the SDK.

In addition, there is TIMOB-25450 which talks about outdated dependencies. I installed npm-check locally to check all outdated versions, which are quite a few. Should I do a separate PR for that or will this PR rule them all? Not sure what's the best approach to update node-deps.

@sgtcoolguy
Copy link
Contributor Author

sgtcoolguy commented Oct 30, 2017 •
edited

@hansemannn When you update the node version to use, you need to ensure that Jenkins master has that node version set up (I'm guessing it doesn't, since I'm the one who has to do that).

I'm adding 8.8.1 now...

@sgtcoolguy
Copy link
Contributor Author

@hansemannn Also, for node dependencies, I'd prefer a new PR for that...

janvennemann
janvennemann requested changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgtcoolguy Building the Android module silently fails on Jenkins. The appc run command seems to have errored out but its still marked as successful and then fails later while trying to package the final zip. Can you take a look? Thanks!

@hansemannn
Copy link
Contributor

@sgtcoolguy Can we use 8.9.0 LTS? 😇

@ewanharris ewanharris mentioned this pull request Nov 3, 2017
Merged
@janvennemann janvennemann mentioned this pull request Nov 8, 2017
Merged
@sgtcoolguy
Copy link
Contributor Author

Requires #232 or #256 be merged first. (Windows module build is failing because of dropped 8.1 support)

@janvennemann janvennemann merged commit cafd474 into tidev:master Nov 9, 2017
@sgtcoolguy sgtcoolguy deleted the apilevel-4 branch November 9, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgtcoolguy @hansemannn @janvennemann @garymathews