Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24862] Pass correct SDK version to CocoaPods build #181

Merged
merged 1 commit into from Jun 21, 2017

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-24862

The -sdk flag for xcodebuild requires the SDK version to be in the format MAJOR.MINOR. To support the recent patch versions of iOS SDK like 10.3.1 this will trim the patch version number.

The sdk flag for xcodebuild requires the SDK version to be in the format MAJOR.MINOR. To support the recent patch versions of iOS SDK like 10.3.1 this will trim the patch version number.
@hansemannn
Copy link
Contributor

@cb1kenobi Can you take a look?

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hansemannn hansemannn merged commit a2351ba into tidev:master Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants