[TIMOB-25402] Fix framework handling regressions #233
Conversation
Fixes two framework handling regression preventing a user to pull in additional system frameworks via appc.js and accidently overwriting the whole FRAMEWORK_SEARCH_PATH build setting.
janvennemann
force-pushed
the
TIMOB-25402
branch
from
ab2476b
to
ce341ff
Compare
| @@ -858,6 +858,60 @@ HyperloopiOSBuilder.prototype.updateXcodeProject = function updateXcodeProject() | |||
| var mainGroupChildren = xobjs.PBXGroup[pbxProject.mainGroup].children; | |||
| var generateUuid = this.builder.generateXcodeUuid.bind(this.builder, xcodeProject); | |||
|
|
|||
| var frameworksGroup = xobjs.PBXGroup[mainGroupChildren.filter(function (child) { return child.comment === 'Frameworks'; })[0].value]; | |||
There was a problem hiding this comment.
[0].value looks very error-prone, should we guard that first? Also, the whole new added code looks a bit too familar, don't we do all that at a different place already? Or was it only in TIMOB?
There was a problem hiding this comment.
Yes, that code is from Hyperloop itself but i removed it during the dynamic framework changes. We used that previously to pull in all referenced system frameworks. Since iOS 7 that is not required anymore because of modules and semantic imports, see this answer on StackOverflow. So i now only use it to pull in explicitly required system frameworks that come from the appc.js setting. All other frameworks don't need to be manually added to the project anymore.
There was a problem hiding this comment.
So this works even when no frameworks are referenced? I‘m ok with the changes then!
Fixes two framework handling regression preventing a user to pull in additional system frameworks via appc.js and accidently overwriting the whole FRAMEWORK_SEARCH_PATH build setting.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25402
Fixes two framework handling regression preventing a user to pull in additional system frameworks via appc.js and accidently overwriting the whole FRAMEWORK_SEARCH_PATH build setting.