Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25428] Fix block scope errors on Node4 #242

Merged
merged 1 commit into from Oct 23, 2017
Merged

[TIMOB-25428] Fix block scope errors on Node4 #242

merged 1 commit into from Oct 23, 2017

Conversation

ewanharris
Copy link
Contributor

@ewanharris ewanharris commented Oct 23, 2017 •
edited

janvennemann
janvennemann approved these changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh, what a stupid mistake -.- That should make it work again.

@janvennemann janvennemann merged commit 0fe1b46 into tidev:master Oct 23, 2017
@hansemannn hansemannn modified the milestones: v2.2.1, v2.3.0 Oct 23, 2017
@hansemannn
Copy link
Contributor

@ewanharris Is this one save or possible subject for errors like the ones in TIMOB?

@ewanharris
Copy link
Contributor Author

@hansemannn Looking at this commit in Chris' lint PR a851644, there appears to be nothing that would cause an error in strict mode, just styling fixes

@hansemannn hansemannn modified the milestones: v2.3.0, v3.0.0 Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewanharris @hansemannn @janvennemann