[TIMOB-25554] Use correct framework header includes #264
Conversation
| @@ -840,7 +840,7 @@ HyperloopiOSBuilder.prototype.generateStubs = function generateStubs(callback) { | |||
| return callback(err); | |||
| } | |||
|
|
|||
| var codeGenerator = new hm.generate.CodeGenerator(sourceSet, this.metabase, this.parserState, modules, this.references); | |||
| var codeGenerator = new hm.generate.CodeGenerator(sourceSet, modules, this); | |||
There was a problem hiding this comment.
I don't like the fact to pass the whole instance to the code-generator. Can we find a different solution? Looks like we don't need all of it's properties. If you pass this.frameworks as a parameter, you should be fine. I know long signatures are also bad in JS, but not sure what's worse :-).
There was a problem hiding this comment.
Passing around objects in JS as arguments is always done by reference so this does not have any negative impact on performance.
There was a problem hiding this comment.
I agree, but it may be unclear for the clarity of used arguments.
There was a problem hiding this comment.
Well, you just have to look into to the constructor if you want to know which properties are used exactly ;) I prefer to pass the object as a whole and let the constructor pick which properties to use. Another benefit, apart from that we don't have to pass 6 parameters around, is that this will also prevent further signature changes should we need another property from the iOS builder in the future.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25554