[TIMOB-25564] Use correct umbrella header import in native helpers #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
reviewed
Nov 29, 2017
| } else { | ||
| m.frameworks[mod.framework] = 1; | ||
| } | ||
| m.frameworks[mod.framework] = 1; |
There was a problem hiding this comment.
Can you explain this change? Is the -Swift suffix handled by the new changes in the code-generator already?
There was a problem hiding this comment.
The new framework metabase already contains the Swift interface header as the umbrella header so the new convertToUmbrellaHeaderImports will set it accordingly.
hansemannn
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25564