[TIMOB-25604] Improve compatibility with CocoaPods #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Pod is only available as a dynamic framework but the use_frameworks! flag is missing, CocoaPods will create a dummy directory in its public header path and link all headers to the backing framework. This fix prevents duplicate parsing of those headers, which caused some follow up issues within the metabase parser.
janvennemann
force-pushed
the
TIMOB-25604
branch
from
2584c55
to
190989d
Compare
hansemannn
approved these changes
Jan 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25604
If a Pod is only available as a dynamic framework but the use_frameworks! flag is missing, CocoaPods will create a dummy directory in its public header path and link all headers to the backing framework. This fix prevents duplicate parsing of those headers, which caused some follow up issues within the metabase parser.
@hansemannn With this i also deprecated the usage of CocoaPods without the
use_frameworks!flag. Frameworks provide some additional information which makes it easier to create a sophisticate matabase from them compared to static libraries.