New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-20469 support building for both Titanium class and Alloy #27
Conversation
Comments which I also posted in the flow: @jhaynie tested the PR using the hyperloop-examples app: Works great on sim, fails during device-build process:
the problem is, that the expression I hope that helps. the only device-related thing i can think of is 9ecc22f. Note: This build-failture did not happen with latest master revision. EDIT: Also tested it with a classic project. The build succeeds (probably because there are no delegates placed in subclasses). Anyway, it fails using this sample. Log:
|
Alloy build succeeds now, but still getting the above error happening with classic projects as well ( |
PR actually works well for me. Having QE to help check one more time before merging. |
Summing up:
You can decide if we should focus on that issue on a different ticket, but I don't feel like we merge too fast now. |
As Hans have clarified. It only errors if I used GUI 111-11-1111... |
CR and FT passed, PR approved! Thanks Jeff! 🚀 |
This PR needs to be well tested before merging and as the chance of breaking things since it's pretty invasive.
To test, you need to first build an SDK from master ensuring this commit.
You need to test both Android and iOS and both Titanium Classic and Titanium Alloy projects separately. We also need to test this with the hyperloop-examples project with these changes.
The other test we need to do is verify that this works both on simulator and device. For a device build, we need to ensure that no source code (objective-C) for iOS or (Java) for Android is in the final package.
I've tried to make minimal changes to make this work. The biggest changes were in iOS. For iOS, I switched to doing the hyperloop JS work on each file instead of all at front -- that way I didn't have to worry about making changes to Resources intermediate files -- instead just making changes to the final destination.
Since this is pretty complicated, I think we should have both @hansemannn and @cheekiatng both review this before merging.