[3_1_X][TIMOB-26455] Sanitize numeric names #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvennemann
approved these changes
Oct 17, 2018
janvennemann
approved these changes
Oct 17, 2018
| @@ -150,6 +150,10 @@ function safeName(name) { | |||
| if (name.match(/^(decodeURI|decodeURIComponent|encodeURI|encodeURIComponent|escape|eval|isFinite|isNaN|parseFloat|parseInt|unescape|uneval)$/)) { | |||
| return '_' + name; | |||
| } | |||
| // Replace numeric prefix | |||
| if (name.match(/^\d+/)) { | |||
There was a problem hiding this comment.
Suggested change
| if (name.match(/^\d+/)) { | |
| if (/^\d+/.test(name)) { |
To just test the string for a match test is considerably faster. Shouldn't be much of an issue here but just for future reference (and i wanted to test the new suggest feature^^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket