Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): remove unused preprocessor defines #313

Merged
merged 1 commit into from Jan 15, 2019

Conversation

janvennemann
Copy link
Contributor

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@keerthi1032
Copy link

keerthi1032 commented Jan 10, 2019

FR Passed. Hyperloop example works fine.no error on app startup. @janvennemann can you please merge this PR . I don't have write access to merge it
Operating System
Name = Mac OS X
Version = 10.13.6
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local sdk
Device = iPhone 6s iOS 12

@janvennemann janvennemann modified the milestones: v4.0.0, v4.0.1 Jan 15, 2019
@janvennemann janvennemann merged commit 4c6f241 into tidev:master Jan 15, 2019
@janvennemann janvennemann deleted the TIMOB-26671 branch January 15, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants