fix: do not re-generate source unnecessarily #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoids unncessary work (small perf improvement?) - A later step already avoided unncessary re-write of JS file - when we do re-generate, pass along options to retain line numbers and comments so that we hopefully do not break source maps.
- Avoids unneccesary work of re-generating source and re-writing file - When we do re-generate, pass along optiosn to retain lines and comments so that we hopefully do not break existing source maps Fixes TIMOB-26876
|
Nice side-effect here - should be a perf boost on both platforms, but probably more pronounced on iOS - since we don't re-generate source from the AST when unmodified, and on iOS we avoid rewriting the file. |
janvennemann
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26876
Description
This explicitly tracks whether we modify the AST in our hyperloop visitors that look for hyperloop
requires/imports. If we do not, avoid calling@babel/generatealtogether and retain the existing original source code.If we do modify, pass along the original source to
generateand options to try and retain line numbers and comments (since we want to not change line numbers from what may already be source mapped, and we don't want to drop the//# sourceMappingURL=comment that points at/inlines the source map).❓ I don't believe Windows does any rewriting of JS, so I don't think there's any fix here necessary for that platform...