New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): xcode 11 / ios 13 compatiility #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@sgtcoolguy , we are waiting for few last fixes from Jan for this & a hyperloop module to test. |
@sgtcoolguy so this got way bigger than expected. I tried to fix some generics handling at first but our metabase parser has a really unbelievably crappy and fragile design so it turned out that i had to go down the rabbit hole to fix any of this. We used to have a very basic generic type handling, which was pretty much hardcoded to the commonly used template params
When we are going to move Hyperloop to the core we should really consider switching to the C++ API of clang for the metabase parser. |
@lokeshchdhry Please check the 4.0.4 Beta 1 release. Also note that the hyperloop-examples project needs some changes because the |
FR Passed Tested with the hyperloop example app, the application built successfully. Test Environment
Waiting on second CR for merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Building the Pods project with
xcodebuild
from Xcode 11 fails ifproject.xcworkspace/contents.xcworkspacedata
is not present. This will generate the file if required to ensure compatibility with Xcode 11.Closes TIMOB-27362