fix(ios): handle new external vector type #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| std::map<std::string, std::string> location; | ||
| hyperloop::getSourceLocation(cursor, unionDef->getContext(), location); | ||
| std::cout << "union: " << displayName << " kind: " << kind << ", " << hyperloop::toJSON(location) << std::endl; | ||
| // std::cerr << "not handled, union: " << displayName << " kind: " << kind << std::endl; |
There was a problem hiding this comment.
If these codes are not required, please remove.
There was a problem hiding this comment.
Usually i would totally agree. But I find my self frequently re-enabling all these outputs that are all over the project when debugging the metabase parser and fixing bugs / adding support for new types.
In the long run we should introduce a global debug/logging flag, but for now i would leave them as is if you don't mind.
|
FR Passed. Module: 5.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27824
The bundled clang lib in Xcode 11.4 adds a new external vector type. Our metabase parser didn't know about it and bailed out because this particular type has now encoding yet (see http://llvm.org/viewvc/llvm-project?view=revision&revision=216301).
The fix for this is two fold. First, I updated the libclang headers so our metabase parser knows about the new type
CXType_ExtVector. It will fallback to treat this asunexposed, which was the previous value for this type. Due to the missing encoding for this type we can't support it right now.Second, i added a check that handles possible future unknown types by only spitting out a warning instead of failing the whole build. Internally these types will be handled the same as unknown/unexposed types that the metabase parser is aware of.