fix(android): rebuilds should release gradle file locks #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated hyperloop version to 5.0.4. - Updated Android min Titanium SDK version to 9.0.2. * Depends on new "gradle-wrapper.js" APIs. - Modified hyperloop clean to run gradle "clean" task to release gradle daemon's file locks. * File locks were preventing Windows from deleting files when building with Titanium 9.0.1.
|
I don't think we need this change anymore. My Titanium SDK change will stop the gradle daemon before this module's build hook can. I'll wait for @ssjsamir to confirm it via PR below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27882
Summary:
5.0.4.9.0.2.gradle-wrapper.jsAPIs.9.0.1.