[TIMOB-20484] Hyperloop: iOS: Local-embedded frameworks not working #34
Conversation
| //For some reason, when using ticore and having custom headers, the original header search path goes missing. | ||
| //FIX ME | ||
| if(!this.builder.tiapp.ios['use-jscore-framework']) { | ||
| addParam('HEADER_SEARCH_PATHS', 'headers'); |
There was a problem hiding this comment.
Use $(inherited), it should add it.
There was a problem hiding this comment.
$(inherited) is already added in line 1008. It won't work when ticore is enabled.
|
@hansemannn addressed comments |
| @@ -365,18 +365,25 @@ module.exports = { | |||
| ios: { | |||
| xcodebuild: { | |||
| flags: { | |||
| FRAMEWORK_SEARCH_PATHS: '/path/to/framework' | |||
| FRAMEWORK_SEARCH_PATHS: '../../src' | |||
There was a problem hiding this comment.
The src directory is placed in the same folder hierarchy as the appc.js, how does it come we specify we to ../../src then?
There was a problem hiding this comment.
It's with reference to the Xcode project in the build folder. Appc.js is really expecting an absolute file reference, we could code it such that no matter if developer puts anything here in appc.js, it will always check in ../../src anyway. What you think
On 5 Jun 2016, at 2:59 AM, Hans Knoechel <notifications@github.commailto:notifications@github.com> wrote:
In documentation/ios.mdhttps://github.com//pull/34#discussion_r65806223:
@@ -365,18 +365,25 @@ module.exports = {
ios: {
xcodebuild: {
flags: {
FRAMEWORK_SEARCH_PATHS: '/path/to/framework'FRAMEWORK_SEARCH_PATHS: '../../src'
The src directory is placed in the same folder hierarchy as the appc.js, how does it come we specify we to ../../src then?
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/34/files/030d77551ca3abe26dd5ff214887b96e2ecb98aa#r65806223, or mute the threadhttps://github.com/notifications/unsubscribe/AIBddPs7-5BNo4uhFSw575lAwVxKwQrwks5qIcsJgaJpZM4IrSUZ.
There was a problem hiding this comment.
100 % agree, we should point to that directory by default.
|
The PR is not working correctly for me: I'm trying to use the AccountKit SDK from Facebook in Titanium Mobile.
It generates some kind of metabase, but after running the build, the following error occurs when clicking "Third-Party Libraries > AccountKit". Other frameworks and classes work. May I have to change something else in the appc.js? |
|
@hansemannn Where's the following errors? We can look through this when we meet. |
|
Tested using our example projects, including third-party frameworks, Cocoapods dependencies and System frameworks. Approved 🚀 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-20484