[TIMOB-23526] Locks down the version of cocoapod hyperloop uses. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the pod command run through bundler which is a good pratice in the ruby world
|
Hey @Sophrinix, I'm considering to use this solution for now, so people can at least use it out of the box. One question outstanding is, if this will change the version only for Hyperloop or globally. So in detail, if people want to use CocoaPods 1.x for other projects, would this PR prevent them? If not, we can go ahead. /cc @cheekiatng |
|
This will only change the version of cocoapods for that mobile app. bundler is local to a given project. |
|
Love it. Can you update to the latest version before 1.x? I think it was 0.39.0. Will merge afterwards |
| @@ -0,0 +1,62 @@ | |||
| GEM | |||
There was a problem hiding this comment.
Does this lock-file need to be part of the commit?
|
Closing in favor of #49 to be able to support both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23526
This locks down the version of cocoapods that we are using and makes the pod command run through bundler which is a good practice in the ruby world.
While this doesn't actually solve the problem of using a version of cocoapod newer than 0.39.0, it does however allow cocoapods to be used again for hyperloop projects.
Not having a Gemfile when you have a ruby dependency is akin to not having a package.json in the node world.
It's good practice in the ruby world to use bundler when calling ruby commands aka
bundle exec pod...as opposed topod ....This buys us time in the short run and in the longer run makes the ruby dependencies more predictable.