Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): support LiveView #351

Merged
merged 3 commits into from Jun 17, 2021
Merged

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented May 28, 2021

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28461

Summary:

  • Support running LiveView with Hyperloop.
    • No longer modifies JS files containing Hyperloop requires/imports. (This was the issue.)
    • Now injects a hyperloop.bootstrap.js providing bindings between native types to JS files.
    • Implemented the same way as Android, which supports LiveView as of Titanium 9.0.0.
  • Removed 3 year old native property access migration code.
  • Updated module version to 7.0.2.

Note:
The following still won't work with LiveView because they require a native rebuild.

  • Adding libraries.
  • Adding Hyperloop.defineClass() calls. (Because it involves native code generation.)

Test:

  1. Add this PR's hyperloop module to hyperloop-examples.
  2. Build and run view LiveView: appc run -p ios --liveview
  3. Go to every window in the example app and verify it works as expected.
  4. While LiveView is running, open file: hyperloop-examples/app/controllers/ios/label.js
  5. Change variable infoString from 'We ♥ iOS' to 'We ♥ LiveView' and save.
  6. Verify app restarts without error.
  7. Go to the app's Label window and verify the text has been updated.

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

Finally, that really horrible import rewriting is gone :) That also makes my live easier for the new LiveView v2, neat!

@jquick-axway jquick-axway merged commit 577e63f into tidev:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants