Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): include missing i386 and armv7 architectures #356

Merged
merged 2 commits into from Jul 22, 2021

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jul 21, 2021

  • Include missing architectures required by the current minimum Titanium SDK requirement for this module (9.2.0)
  • Instead of enforcing 10.0.0, this module version will take precidence over older incompatible modules when using 9.2.X SDKs
TEST CASE
  • Building a project that includes Hyperloop 7.0.4 with Titanium SDK 9.2.X should not fail

JIRA Ticket

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@jquick-axway
Copy link
Contributor

@garymathews , maybe instead of closing the following PR, we should update it to target this PR's module version and set it up to be back-ported. We should still get @lokeshchdhry to test its iOS LiveView support in 9.2.x and 10.0.x.
tidev/titanium-sdk#12905

@jquick-axway jquick-axway merged commit e7b7141 into tidev:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants