[TIMOB-23652] Fix Swift-compiling in iOS10 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please cherry-pick the last commit. And did you test your changes on different sims and devices before? |
This reverts commit a9b17b5.
This will choose the targeted simulator architecture based and the architecture of the current node process, which can either be i386 or x86_64.
|
Cherry-picked your last commit and made my changes on top of it. I was only able to test the simulator, which runs fine with these changes. Unfortunately, i do not have any ios devices to test with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23652
Same as #40, but with dynamic simulator arch detection.